Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display empty menu item for non-visible submenus (backport: 5-0-x) #16848

Conversation

Projects
None yet
1 participant
@trop
Copy link
Contributor

commented Feb 8, 2019

Backport of #16832

See that PR for details.

Notes: Fixed issue whereby a user was not well informed when interacting with a menu submenu that did not have any visible MenuItems.

@trop trop bot requested a review from as a code owner Feb 8, 2019

@trop trop bot referenced this pull request Feb 8, 2019

Merged

fix: display empty menu item for non-visible submenus #16832

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Feb 8, 2019

@codebytere codebytere merged commit 91a67e4 into electron:5-0-x Feb 8, 2019

4 of 8 checks passed

build-linux Workflow: build-linux
Details
build-mac-fork-prs Workflow: build-mac-fork-prs
Details
appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 8, 2019

Release Notes Persisted

Fixed issue whereby a user was not well informed when interacting with a menu submenu that did not have any visible MenuItems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.