Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak when using webFrame and spell checker (backport: 5-0-x) #16851

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Feb 8, 2019

Backport of #16770

See that PR for details.

Notes: Fix memory leak when using webFrame and spell checker.

zcbenz added some commits Feb 6, 2019

fix: do not create native api::WebFrame in webFrame
When reloading a page without restarting renderer process (for example
sandbox mode), the blink::WebFrame is not destroyed, but api::WebFrame
is always recreated for the new page context. This leaves a leak of
api::WebFrame.

@trop trop bot requested a review from as a code owner Feb 8, 2019

@trop trop bot referenced this pull request Feb 8, 2019

Merged

Fix memory leak when using webFrame and spell checker #16770

4 of 6 tasks complete

@trop trop bot added 5-0-x backport labels Feb 8, 2019

@MarshallOfSound MarshallOfSound merged commit 8b5f26a into electron:5-0-x Feb 8, 2019

6 of 8 checks passed

build-mac-fork-prs Workflow: build-mac-fork-prs
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 8, 2019

Release Notes Persisted

Fix memory leak when using webFrame and spell checker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.