Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify netLog.stopLogging() #16862

Merged
merged 1 commit into from Feb 19, 2019

Conversation

@miniak
Copy link
Contributor

commented Feb 9, 2019

Description of Change

This PR promisifies netLog.stopLogging()

Depends on #16935

/cc @codebytere

Checklist

Release Notes

Notes: Converted netLog.stopLogging() to return a Promise instead of taking a callback.

@miniak miniak requested a review from codebytere Feb 9, 2019

@miniak miniak requested review from as code owners Feb 9, 2019

@miniak miniak force-pushed the miniak/promisify-netlog branch 2 times, most recently from a0285f0 to ba62322 Feb 9, 2019

@miniak miniak self-assigned this Feb 9, 2019

@miniak miniak added target/5-0-x and removed target/5-0-x labels Feb 9, 2019

@miniak miniak force-pushed the miniak/promisify-netlog branch from ba62322 to 8352b46 Feb 9, 2019

@miniak miniak force-pushed the miniak/promisify-netlog branch 2 times, most recently from 3196558 to 0730e60 Feb 13, 2019

@jkleinsc
Copy link
Contributor

left a comment

Looks good to me except for a small doc change.

Show resolved Hide resolved docs/api/net-log.md Outdated

@miniak miniak force-pushed the miniak/promisify-netlog branch from 0730e60 to ce9d63e Feb 15, 2019

@jkleinsc

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

Arm CI is failing on this PR for a reason unrelated to this PR. #16992 will resolve that issue.

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Feb 18, 2019

@jkleinsc can you please merge?

@alexeykuzmin alexeykuzmin merged commit 7e7abc2 into master Feb 19, 2019

13 of 15 checks passed

electron-arm-testing Build #20190219.8 has failed
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190215.11 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 19, 2019

Release Notes Persisted

Converted netLog.stopLogging() to return a Promise instead of taking a callback.

@alexeykuzmin alexeykuzmin deleted the miniak/promisify-netlog branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.