Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Remove redundant 'Instance Events' Headline #16865

Merged
merged 1 commit into from Feb 15, 2019

Conversation

@aayushchhabra
Copy link
Contributor

commented Feb 10, 2019

Description of Change

Remove redundant 'Instance Events' Headline

Checklist

Release Notes

Notes: In the Menu Docs 'Instance Events' Headline is wrongly repeated.

@jkleinsc
Copy link
Contributor

left a comment

Overall looks good, but it appears that the first instance of the Instance Events section does not included the phrase: "returned by Menu.buildFromTemplate". Can you add that so that we don't lose that bit of information?

@aayushchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Feb 13, 2019

Makes sense ... I'll add the line and update the PR ...

@aayushchhabra aayushchhabra force-pushed the aayushchhabra:master branch from 33e989e to 2d52f74 Feb 14, 2019

@aayushchhabra aayushchhabra force-pushed the aayushchhabra:master branch from 2d52f74 to 27e052c Feb 14, 2019

@aayushchhabra

This comment has been minimized.

Copy link
Contributor Author

commented Feb 14, 2019

@jkleinsc I squashed the commits together, so I can't see your change request anymore ...

@codebytere
Copy link
Member

left a comment

lgtm with latest changes!

@jkleinsc jkleinsc merged commit 6d005ff into electron:master Feb 15, 2019

9 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 15, 2019

Release Notes Persisted

In the Menu Docs 'Instance Events' Headline is wrongly repeated.

@welcome

This comment has been minimized.

Copy link

commented Feb 15, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.