Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chrome.runtime.getManifest #16891

Merged

Conversation

@samuelmaddock
Copy link
Member

commented Feb 12, 2019

Description of Change

Implements chrome.runtime.getManifest API.

Checklist

Release Notes

Notes: Added chrome.runtime.getManifest API for Chrome extensions.

@samuelmaddock samuelmaddock requested a review from as a code owner Feb 12, 2019

@samuelmaddock samuelmaddock force-pushed the samuelmaddock:chrome-api-runtime-getManifest branch from 2207c1c to 3f66e4b Feb 12, 2019

@samuelmaddock samuelmaddock force-pushed the samuelmaddock:chrome-api-runtime-getManifest branch from 3f66e4b to 177bcae Feb 12, 2019

Show resolved Hide resolved lib/browser/chrome-extension.js Outdated
Show resolved Hide resolved lib/renderer/chrome-api.js Outdated
@miniak

miniak approved these changes Feb 12, 2019

@jkleinsc jkleinsc merged commit 8f6a543 into electron:master Feb 13, 2019

9 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be merged or rebased
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@welcome

This comment has been minimized.

Copy link

commented Feb 13, 2019

Congrats on merging your first pull request! 🎉🎉🎉

@release-clerk

This comment has been minimized.

Copy link

commented Feb 13, 2019

Release Notes Persisted

Added chrome.runtime.getManifest API for Chrome extensions.

@samuelmaddock samuelmaddock deleted the samuelmaddock:chrome-api-runtime-getManifest branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.