Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify app.dock.show() #16904

Merged
merged 2 commits into from Feb 13, 2019

Conversation

@codebytere
Copy link
Member

commented Feb 12, 2019

Description of Change

Resolves #13047.

app.dock.show() was previously an asynchronous function that did not take a callback, so devs needed to employ unsavory timeouts and other things in order to give deterministic behavior to their users. This converts that method to return a Promise, which ameliorates that issue and also serves the modernization initiative.

cc @miniak @deepak1556 @ckerr @MarshallOfSound

Checklist

Release Notes

Notes: Converted app.dock.show() such that it now returns a Promise.

@codebytere codebytere requested review from as code owners Feb 12, 2019

@codebytere codebytere changed the title feat: promisify app.dock.show [wip] feat: promisify app.dock.show Feb 12, 2019

@codebytere codebytere force-pushed the promise-dock-show branch from 770d497 to ae90c43 Feb 12, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Feb 12, 2019

Only comment, is it at all possible to test this?

@codebytere codebytere changed the title [wip] feat: promisify app.dock.show feat: promisify app.dock.show Feb 12, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 12, 2019

i'm not sure how CI would react to this but i can test that the promise resolves i guess?

@codebytere codebytere force-pushed the promise-dock-show branch from 4e63137 to da8b959 Feb 12, 2019

@codebytere codebytere changed the title feat: promisify app.dock.show feat: promisify app.dock.show() Feb 12, 2019

codebytere added some commits Feb 12, 2019

@codebytere codebytere force-pushed the promise-dock-show branch from da8b959 to 293f8d8 Feb 12, 2019

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 13, 2019

app module BrowserWindow events should emit remote-require event when remote.require() is invoked - should emit remote-require event when remote.require() is invoked

flaked on linux x64 which is unrelated.

@codebytere codebytere merged commit ca83d36 into master Feb 13, 2019

13 of 15 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190212.36 succeeded
Details
electron-arm64-testing Build #20190212.35 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 13, 2019

Release Notes Persisted

Converted app.dock.show() such that it now returns a Promise.

@codebytere codebytere deleted the promise-dock-show branch Feb 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.