Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport patch to sync exposed crypto (backport: 4-0-x) #16912

merged 4 commits into from Feb 13, 2019


None yet
2 participants
Copy link

trop bot commented Feb 12, 2019

Backport of #16822

See that PR for details.

Notes: Added a patch to fix incorrect enumeration and instantiation of Node.js ciphers in the Crypto module.

@trop trop bot requested a review from as a code owner Feb 12, 2019

@trop trop bot referenced this pull request Feb 12, 2019


fix: backport patch to sync exposed crypto #16822

4 of 5 tasks complete

@trop trop bot added 4-1-x backport labels Feb 12, 2019


This comment has been minimized.

Copy link

nornagon commented Feb 13, 2019

merging; ci appears to be flake

@nornagon nornagon merged commit 4f63509 into electron:4-0-x Feb 13, 2019

3 of 4 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Semantic Pull Request ready to be squashed
appveyor: win-x64-testing-pr AppVeyor build succeeded
release-notes Release notes found

This comment has been minimized.

Copy link

release-clerk bot commented Feb 13, 2019

Release Notes Persisted

Some ciphers that were listed in crypto.getCiphers() were not instantiable with crypto.createCipheriv(). Now they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.