Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify debugger.sendCommand() (backport: 5-0-x) #16931

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Feb 13, 2019

Backport of #16861

See that PR for details.

Notes: Converted debugger.sendCommand() to return a Promise instead of taking a callback.

@trop trop bot requested review from as code owners Feb 13, 2019

@trop trop bot referenced this pull request Feb 13, 2019

Merged

feat: promisify debugger.sendCommand() #16861

6 of 6 tasks complete

@trop trop bot added 5-0-x backport labels Feb 13, 2019

@jkleinsc jkleinsc merged commit b4bd96b into electron:5-0-x Feb 13, 2019

7 of 8 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac-fork-prs Workflow: build-mac-fork-prs
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 13, 2019

Release Notes Persisted

Converted debugger.sendCommand() to return a Promise instead of taking a callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.