Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable inputpane virtual keyboard by default #16944

Merged
merged 1 commit into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

nornagon commented Feb 13, 2019

Description of Change

First commit here is just running git-import-patches followed by git-export-patches. The second commit backports https://chromium-review.googlesource.com/c/chromium/src/+/946928 to enable the inputpane virtual keyboard by default, which should fix some scenarios in Windows 10 RS4 and later in which the virtual keyboard wasn't showing when it should have.

Checklist

Release Notes

Notes: Fixed an issue on Windows 10 RS4 and later that was causing the virtual keyboard not to appear when focusing some input fields.

@nornagon nornagon requested a review from brenca Feb 13, 2019

@nornagon nornagon requested a review from as a code owner Feb 13, 2019

@deepak1556
Copy link
Member

deepak1556 left a comment

LGTM, any reason patch was preferred over passing it to --enable-features ?

@nornagon

This comment has been minimized.

Copy link
Contributor Author

nornagon commented Feb 14, 2019

I prefer the backport because:

  1. it'll disappear automatically when rebasing (though i suppose in this case, since it's already gone on master, this isn't really an advantage)
  2. it's nice to have a direct backport of code that i know is in chrome
  3. this allows disabling the feature with --disable-features rather than forcing it
  4. i don't know where the "pass extra things to --enable-features" code in Electron is 😅
fix: enable inputpane virtual keyboard by default
backports e6c18518b from chromium, fixes #13832

@nornagon nornagon force-pushed the fix-virtual-keyboard branch from 63b86c1 to d1892c2 Feb 14, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

deepak1556 commented Feb 14, 2019

1 and 2 are compelling reasons to have this as a patch :)

Regarding 4 , they are in AtomBrowserMainParts::InitializeFeatureList

@jkleinsc jkleinsc merged commit 969ac4c into 4-0-x Feb 15, 2019

8 checks passed

Semantic Pull Request ready to be merged or rebased
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 15, 2019

Release Notes Persisted

Fixed an issue on Windows 10 RS4 and later that was causing the virtual keyboard not to appear when focusing some input fields.

@jkleinsc jkleinsc deleted the fix-virtual-keyboard branch Feb 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.