Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderer hang in cc BeginMainFrame #16946

Merged
merged 2 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@nornagon
Copy link
Contributor

nornagon commented Feb 13, 2019

Description of Change

This backports a change from Chromium that fixes a rare renderer hang in the BeginMainFrame method. The bug in Chromium is view-restricted, but enne@ indicated that this is the change that should fix the issue: https://chromium-review.googlesource.com/c/chromium/src/+/1419132

It's already present in m72 so 5-0-x should be fine. https://chromium-review.googlesource.com/c/chromium/src/+/1427521

Checklist

Release Notes

Notes: Fixed a rare renderer hang in cc::ProxyMain::BeginMainFrame.

nornagon added some commits Feb 13, 2019

@nornagon nornagon requested a review from as a code owner Feb 13, 2019

@jkleinsc jkleinsc merged commit 7a285cd into 4-0-x Feb 14, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 14, 2019

Release Notes Persisted

Fixed a rare renderer hang in cc::ProxyMain::BeginMainFrame.

@jkleinsc jkleinsc deleted the hang-fix branch Feb 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.