Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show user gesture type in click event #16954

Merged
merged 1 commit into from Feb 20, 2019

Conversation

@codebytere
Copy link
Member

commented Feb 14, 2019

Description of Change

Resolves: #16947

Adds a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Added a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

@jkleinsc
Copy link
Contributor

left a comment

Should there be a doc change for this?

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Feb 15, 2019

@jkleinsc this is part of a messy jigsaw puzzle happening in the past few days! This PR is pending merge of #16966, at which time that new structure declaration will be updated to reflect this new Event property :)

@codebytere codebytere force-pushed the show-trigger-type branch from 323aaa3 to 697fddd Feb 15, 2019

@codebytere codebytere requested a review from as a code owner Feb 15, 2019

@codebytere codebytere removed the blocked label Feb 15, 2019

@codebytere codebytere force-pushed the show-trigger-type branch from 697fddd to e28470a Feb 19, 2019

@codebytere codebytere force-pushed the show-trigger-type branch from e28470a to 46b8579 Feb 19, 2019

@codebytere codebytere merged commit 3edc497 into master Feb 20, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190219.4 succeeded
Details
electron-arm64-testing Build #20190219.5 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 20, 2019

Release Notes Persisted

Added a new Event property triggeredByAccelerator, which is called back in custom click events on MenuItems.

@codebytere codebytere deleted the show-trigger-type branch Feb 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.