Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document the Event interface #16966

Merged
merged 3 commits into from Feb 15, 2019

Conversation

@codebytere
Copy link
Member

commented Feb 14, 2019

Description of Change

Document the Event interface in coordination with electron/typescript-definitions#131.

cc @MarshallOfSound

Checklist

Release Notes

Notes: Documented the Event interface as an API structure.

@codebytere codebytere requested a review from as a code owner Feb 14, 2019

@codebytere codebytere force-pushed the add-event-structure branch 2 times, most recently from ae1570c to 9f1f45b Feb 14, 2019

@codebytere codebytere requested a review from MarshallOfSound Feb 14, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Feb 14, 2019

I'm not quite sure how to make it extend GlobalEvent

This would require updates to docs-linter and typescript-definitions to understand "extends"

@codebytere codebytere changed the title docs: document the Event interface [wip] docs: document the Event interface Feb 14, 2019

@codebytere codebytere force-pushed the add-event-structure branch from 9f1f45b to 241098c Feb 14, 2019

@codebytere codebytere requested a review from as a code owner Feb 14, 2019

@codebytere codebytere changed the title [wip] docs: document the Event interface docs: document the Event interface Feb 15, 2019

@codebytere codebytere referenced this pull request Feb 15, 2019

Merged

feat: show user gesture type in click event #16954

4 of 4 tasks complete

@codebytere codebytere force-pushed the add-event-structure branch from e3ea1d7 to 468c01b Feb 15, 2019

@codebytere codebytere merged commit 1e8ac79 into master Feb 15, 2019

12 of 17 checks passed

Backportable? - 4-0-x Backport Failed
Details
Backportable? - 5-0-x Backport Failed
Details
appveyor: win-ia32-testing Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190215.16 succeeded
Details
electron-arm64-testing Build #20190215.16 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 15, 2019

Release Notes Persisted

Documented the Event interface as an API structure.

@codebytere codebytere deleted the add-event-structure branch Feb 15, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

I was unable to backport this PR to "4-0-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/4-0-x label Feb 15, 2019

@trop

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.