Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make torque patch more specific for native arm builds #16992

Merged
merged 3 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@jkleinsc
Copy link
Contributor

jkleinsc commented Feb 15, 2019

Fixes #16985

The v8_generator_toolchain should only be overridden if the snapshot toolchain is a native arm or arm64 toolchain.

Description of Change

Checklist

Release Notes

Notes: no-notes

build: make torque patch more specific
the v8_generator_toolchain should only be overriden if the snapshot toolchain is a native arm or arm64 toolchain

@jkleinsc jkleinsc requested a review from as a code owner Feb 15, 2019

@jkleinsc jkleinsc merged commit 35c3a7e into master Feb 18, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Feb 18, 2019

No Release Notes

@trop

This comment has been minimized.

Copy link
Contributor

trop bot commented Feb 18, 2019

I have automatically backported this PR to "5-0-x", please check out #17019

@trop trop bot added in-flight/5-0-x and removed target/5-0-x labels Feb 18, 2019

@jkleinsc jkleinsc deleted the fix-arm-builds branch Feb 18, 2019

@trop trop bot added merged/5-0-x and removed in-flight/5-0-x labels Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.