Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: make torque patch more specific for native arm builds #16992
+9
−14
Conversation
jkleinsc
added
the
target/5-0-x
label
Feb 15, 2019
jkleinsc
requested a review
from
as a
code owner
Feb 15, 2019
This was referenced Feb 15, 2019
MarshallOfSound
approved these changes
Feb 15, 2019
jkleinsc
merged commit 35c3a7e
into
master
Feb 18, 2019
8 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Feb 18, 2019
|
No Release Notes |
trop
bot
referenced this pull request
Feb 18, 2019
Merged
build: make torque patch more specific for native arm builds (backport: 5-0-x) #17019
This comment has been minimized.
This comment has been minimized.
|
I have automatically backported this PR to "5-0-x", please check out #17019 |
trop
bot
added
in-flight/5-0-x
and removed
target/5-0-x
labels
Feb 18, 2019
jkleinsc
deleted the
fix-arm-builds
branch
Feb 18, 2019
trop
bot
added
merged/5-0-x
and removed
in-flight/5-0-x
labels
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jkleinsc commentedFeb 15, 2019
Fixes #16985
The v8_generator_toolchain should only be overridden if the snapshot toolchain is a native arm or arm64 toolchain.
Description of Change
Checklist
npm testpassesRelease Notes
Notes: no-notes