Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix MenuItem `windowMenu` role description (backport: 5-0-x) #17118

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Feb 25, 2019

Backport of #17065

See that PR for details.

Notes: Fixed MenuItem windowMenu role description to account for changing of Close to Zoom.

@trop trop bot requested a review from as a code owner Feb 25, 2019

@trop trop bot added 5-0-x backport labels Feb 25, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Feb 26, 2019

@codebytere codebytere merged commit 119382b into electron:5-0-x Feb 27, 2019

7 of 8 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 27, 2019

Release Notes Persisted

Fixed MenuItem windowMenu role description to account for changing of Close to Zoom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.