Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
refactor: make shell.ShowItemInFolder asynchronous #17121
Description of Change
BREAKING CHANGE: change return type of
deepak1556 left a comment •
There should be another sweep in the codebase to mark other blocking call sites, also whats the benefit of these two apis returning synchronous boolean results ? If it can be deprecated for async version, we could offload the task to a different thread.
zcbenz left a comment
The windows CI fails with:
It seems that blocking calls are disallowed somewhere up in the call stack.