Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set cancelId to 1 when defaultId == 0 and no 'cancel' button (backport: 5-0-x) #17150

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Feb 27, 2019

Backport of #17123

See that PR for details.

Notes: Fixed defaultId not taking affect when set to 0 and no "cancel" button was present on macOS

@electron-cation electron-cation bot removed the new-pr 🌱 label Feb 27, 2019

@codebytere codebytere merged commit 4f3d611 into electron:5-0-x Feb 27, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Feb 27, 2019

Release Notes Persisted

Fixed defaultId not taking affect when set to 0 and no "cancel" button was present on macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.