Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify session cache methods #17185

Merged
merged 1 commit into from Mar 8, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 1, 2019

Description of Change

Promisify session.getCacheSize() and session.clearCache().

cc @deepak1556 @zcbenz

Checklist

Release Notes

Notes: Converted session.getCacheSize() and session.clearCache() to return promises instead of taking callbacks.

@codebytere codebytere force-pushed the promisify-session branch from 1b9066b to c542b9e Mar 1, 2019

@codebytere codebytere marked this pull request as ready for review Mar 1, 2019

atom/browser/api/atom_api_session.cc Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 2, 2019

docs/api/session.md Outdated Show resolved Hide resolved

@codebytere codebytere force-pushed the promisify-session branch from 5ce4a17 to f4617b8 Mar 4, 2019

@deepak1556

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

Would like to see this cleaned up after the suggested code style changes in #17222

@codebytere codebytere force-pushed the promisify-session branch from f4617b8 to 9a60256 Mar 5, 2019

@codebytere codebytere changed the title feat: promisify some session methods feat: promisify session cachemethods Mar 7, 2019

@codebytere codebytere changed the title feat: promisify session cachemethods feat: promisify session cache methods Mar 7, 2019

docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Outdated Show resolved Hide resolved
docs/api/session.md Show resolved Hide resolved
@miniak

miniak approved these changes Mar 7, 2019

@codebytere codebytere force-pushed the promisify-session branch from 54cff0a to f2f444c Mar 8, 2019

@codebytere codebytere requested a review from deepak1556 Mar 8, 2019

@deepak1556
Copy link
Member

left a comment

LGTM, with some style changes.

atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved
atom/browser/api/atom_api_session.cc Outdated Show resolved Hide resolved

@codebytere codebytere force-pushed the promisify-session branch from f2f444c to 961c038 Mar 8, 2019

@codebytere codebytere force-pushed the promisify-session branch from 961c038 to 2f8d113 Mar 8, 2019

@codebytere codebytere merged commit fc10620 into master Mar 8, 2019

11 of 13 checks passed

appveyor: win-x64-testing Waiting for AppVeyor build to complete
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190308.60 succeeded
Details
electron-arm64-testing Build #20190308.61 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 8, 2019

Release Notes Persisted

Converted session.getCacheSize() and session.clearCache() to return promises instead of taking callbacks.

@codebytere codebytere deleted the promisify-session branch Mar 8, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.