New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable NodeIntegrationInSubFrames for webview #17226
feat: enable NodeIntegrationInSubFrames for webview #17226
Conversation
e37b7f9
to
b66755d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you fix the conflicts. Thanks!
@deepak1556 I'm on it |
b66755d
to
ef4c3da
Compare
This is a feature that is targeting 5, cc @electron/wg-releases |
2bd6def
to
bf1ff75
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, approving for the native changes. Would love review on tests.
Its just a personal style, better to duplicate the tests with their own configs rather than automating different configs with single variation. The latter seems hard on review.
@deepak1556 I followed the existing code's style with the test generation, and I think it makes sense here to not duplicate code just for those flipped flags, but I'm happy to change it up. I'll ask some folks for their opinion. |
Personally I'd rather not duplicate the tests because the intention here is to test that the behavior is identical for different configurations. If we duplicate then they will diverge or it will become a pain to update in the future. We've used this test generation pattern in quite a few places now |
e8a437c
to
e1c6b14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on behalf of Releases WG, and will do the same for the 5-0-x
bp, which unfortunately is going to need to be manual.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record, @electron/wg-releases approved this for 5-0-x
in the 2019-03-13 meeting
Thanks for the update guys! Fortunately the backport only failed because of the ongoing typescript conversion, should be straightforward to migrate the conflicting changes back to JS. I'll get to it once this is merged and I have internet again (probably tomorrow at the soonest) |
Release Notes Persisted
|
I was unable to backport this PR to "5-0-x" cleanly; |
A maintainer has manually backported this PR to "5-0-x", please check out #17398 |
1 similar comment
A maintainer has manually backported this PR to "5-0-x", please check out #17398 |
* feat: enable nodeIntegrationInSubFrames for webview * test: add tests * docs: document webview's nodeintegrationinsubframes * lint: fix indent * fix: resolve some merge bloopers
Description of Change
This was previously not done because of a crash. electron/node#94 fixes that crash, and allow us to enable this option for the
webview
. The node PR also fixes #16733.Fixes #16780.
Checklist
npm test
passesRelease Notes
Notes: Enabled
NodeIntegrationInSubFrames
option usage forwebview
tags.