Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: enable NodeIntegrationInSubFrames for webview #17226
Description of Change
deepak1556 left a comment
LGTM, approving for the native changes. Would love review on tests.
Its just a personal style, better to duplicate the tests with their own configs rather than automating different configs with single variation. The latter seems hard on review.
Personally I'd rather not duplicate the tests because the intention here is to test that the behavior is identical for different configurations.
If we duplicate then they will diverge or it will become a pain to update in the future. We've used this test generation pattern in quite a few places now
Mar 8, 2019
Thanks for the update guys! Fortunately the backport only failed because of the ongoing typescript conversion, should be straightforward to migrate the conflicting changes back to JS. I'll get to it once this is merged and I have internet again (probably tomorrow at the soonest)