Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upbuild: Update TypeScript, use @typescript-eslint #17251
+104
−92
Conversation
felixrieseberg
added some commits
Mar 6, 2019
felixrieseberg
requested review from
codebytere and
MarshallOfSound
Mar 6, 2019
felixrieseberg
marked this pull request as ready for review
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
The |
MarshallOfSound
approved these changes
Mar 7, 2019
MarshallOfSound
merged commit 5581990
into
master
Mar 7, 2019
8 checks passed
Semantic Pull Request
ready to be squashed
Details
appveyor: win-ia32-debug
AppVeyor build succeeded
Details
appveyor: win-ia32-testing
AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr
AppVeyor build succeeded
Details
appveyor: win-x64-debug
AppVeyor build succeeded
Details
appveyor: win-x64-testing
AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr
AppVeyor build succeeded
Details
release-notes
Release notes found
This comment has been minimized.
This comment has been minimized.
release-clerk
bot
commented
Mar 7, 2019
|
No Release Notes |
MarshallOfSound
deleted the
update-typescript
branch
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
felixrieseberg commentedMar 6, 2019
Description of Change
This PR updates our TypeScript version to 3.3.3333 (don't ask), which is an all-around better version of TypeScript without breaking any code we have today.
That upgrade surfaced an issue with typescript-eslint-parser, which is deprecated and archived. The new kid on the block is typescript-eslint, which is better and actually found some issues in our code.
The only change that requires explanation is the removal of
.eslintrcfiles that are overriding ourmoduledefinition withscriptdefinitions. That declaration is incorrect as soon as TypeScript rolls around, which compiles in module mode (outputting a script, but that's none of ESLint's concern).Checklist
npm testpassesRelease Notes
Notes: no-notes