Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update TypeScript, use @typescript-eslint #17251

merged 2 commits into from Mar 7, 2019


None yet
2 participants
Copy link

felixrieseberg commented Mar 6, 2019

Description of Change

This PR updates our TypeScript version to 3.3.3333 (don't ask), which is an all-around better version of TypeScript without breaking any code we have today.

That upgrade surfaced an issue with typescript-eslint-parser, which is deprecated and archived. The new kid on the block is typescript-eslint, which is better and actually found some issues in our code.

The only change that requires explanation is the removal of .eslintrc files that are overriding our module definition with script definitions. That declaration is incorrect as soon as TypeScript rolls around, which compiles in module mode (outputting a script, but that's none of ESLint's concern).


Release Notes

Notes: no-notes

@felixrieseberg felixrieseberg marked this pull request as ready for review Mar 7, 2019


This comment has been minimized.

Copy link
Member Author

felixrieseberg commented Mar 7, 2019

The mksnapshot test failure in arm is unrelated 🙇

@MarshallOfSound MarshallOfSound merged commit 5581990 into master Mar 7, 2019

8 checks passed

Semantic Pull Request ready to be squashed
appveyor: win-ia32-debug AppVeyor build succeeded
appveyor: win-ia32-testing AppVeyor build succeeded
appveyor: win-ia32-testing-pr AppVeyor build succeeded
appveyor: win-x64-debug AppVeyor build succeeded
appveyor: win-x64-testing AppVeyor build succeeded
appveyor: win-x64-testing-pr AppVeyor build succeeded
release-notes Release notes found

This comment has been minimized.

Copy link

release-clerk bot commented Mar 7, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the update-typescript branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.