Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad assertion in crypto functions that use BN_bn2bin_padded (backport: 5-0-x) #17255

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Mar 7, 2019

Backport of #17220

See that PR for details.

Notes: Fixed an assertion when calling ECDH.getPrivateKey(), diffieHellman.generateKeys() or diffieHellman.get*().

nornagon added some commits Mar 4, 2019

chore: roll node
in particular, this picks up electron/node#70a78f07b, which fixes an issue with incorrect usage of the BN_bn2bin_padded API in boringssl

@trop trop bot referenced this pull request Mar 7, 2019

Merged

fix: bad assertion in crypto functions that use BN_bn2bin_padded #17220

3 of 6 tasks complete

@trop trop bot added 5-0-x backport labels Mar 7, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 7, 2019

@nornagon
Copy link
Contributor

left a comment

i'm not sure that node version is correct, holding

@nornagon
Copy link
Contributor

left a comment

checked it, it's fine :)

@MarshallOfSound MarshallOfSound merged commit 2c9b4d1 into electron:5-0-x Mar 7, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 7, 2019

Release Notes Persisted

Fixed an assertion when calling ECDH.getPrivateKey(), diffieHellman.generateKeys() or diffieHellman.get*().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.