Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
feat: add support for content scripts 'all_frames' option #17258
Description of Change
Adds support for Chrome extension content script option all_frames.
These changes will only work with the non-sandboxed renderer until #16218 is merged.
referenced this pull request
Mar 7, 2019
Mar 8, 2019
Mar 8, 2019
8 of 9 checks passed
@samuelmaddock on Electron 6.0.0-nightly.20190311 i cant get my extension to run on all frames.
On chrome im getting multiple logs of the iframe urls. On electron im only getting printout of the top frame.
had a look at nightly#6.0.0-nightly.20190311 source (https://github.com/electron/electron/tree/b43e4b8e0e93eedd466a2794e02e0452f27407d9) and it seems that both this #17258 and #16218 are there.
What am i missing ?
@samuelmaddock Great! That solved the issue but raised more issues...
Since there is a known issue in Electron with sendResponse not working, i wanted to use the tabs API to respond to the sender but i can't send the message to a specific frame...
Seems there is more stuff to do for full extensions support. Is there any time frame for #17440 ?