Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make StreamSubscriber ref counted (backport: 4-1-x) #17267

Merged
merged 1 commit into from Mar 29, 2019

Conversation

Projects
None yet
2 participants
@deepak1556
Copy link
Member

deepak1556 commented Mar 7, 2019

Description of Change

Backport of #17221

Checklist

Release Notes

Notes: Fix app freeze when using custom stream protocol

@trop trop bot referenced this pull request Mar 7, 2019

Merged

fix: make StreamSubscriber ref counted #17221

4 of 6 tasks complete

@deepak1556 deepak1556 added the wip label Mar 7, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 8, 2019

fix: make StreamSubscriber ref counted
It is owned by URLRequestStreamJob on the IO thread once request starts,
but if the ownership was abondoned while transfering it to IO thread
which is possible when a request is aborted, then we need to make sure
its destroyed on the right thread to avoid lock in v8.

@deepak1556 deepak1556 force-pushed the stream_crash_4-0-x branch from bff7268 to 1e2adfc Mar 17, 2019

@deepak1556 deepak1556 removed the wip label Mar 17, 2019

@deepak1556 deepak1556 changed the base branch from 4-0-x to 4-1-x Mar 18, 2019

@deepak1556 deepak1556 changed the title fix: make StreamSubscriber ref counted (backport: 4-0-x) fix: make StreamSubscriber ref counted (backport: 4-1-x) Mar 18, 2019

@jkleinsc jkleinsc requested a review from zcbenz Mar 29, 2019

@jkleinsc jkleinsc merged commit 8fd91cc into 4-1-x Mar 29, 2019

6 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 29, 2019

Release Notes Persisted

Fix app freeze when using custom stream protocol

@jkleinsc jkleinsc deleted the stream_crash_4-0-x branch Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.