Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: disable gpg signing in git-import-patches #17282

Merged
merged 1 commit into from Mar 8, 2019

Conversation

Projects
None yet
3 participants
@codebytere
Copy link
Member

codebytere commented Mar 8, 2019

Description of Change

Ensure that gpg signing is turned off during patch application. This guards against the case where the user has commit.gpgsign=true in their .gitconfig, which can cause the sync to fail due to gpg requesting a passphrase.

cc @nornagon

Checklist

Release Notes

Notes: no-notes

@nornagon nornagon changed the title build: turn gpg signing off for bootstrap build: disable gpg signing in git-import-patches Mar 8, 2019

@MarshallOfSound MarshallOfSound merged commit 17dab8f into master Mar 8, 2019

8 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 8, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the do-not-sign branch Mar 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.