Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify session.getBlobData() #17303

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 9, 2019

Description of Change

Promisifies session.getBlobData().

cc @deepak1556 @miniak @zcbenz

Checklist

Release Notes

Notes: Converted session.getBlobData() to return a Promise instead of taking a callback.

@codebytere codebytere force-pushed the promisify-session-getblobdata branch from b619aa4 to faa97e2 Mar 9, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 10, 2019

@codebytere codebytere force-pushed the promisify-session-getblobdata branch from faa97e2 to 896ba3b Mar 11, 2019

@codebytere codebytere force-pushed the promisify-session-getblobdata branch 3 times, most recently from 8f6f474 to e0470f9 Mar 11, 2019

Show resolved Hide resolved atom/browser/atom_blob_reader.cc Outdated
Show resolved Hide resolved atom/browser/api/atom_api_session.cc Outdated
Show resolved Hide resolved atom/browser/atom_blob_reader.cc Outdated

@codebytere codebytere requested a review from zcbenz Mar 13, 2019

@codebytere codebytere force-pushed the promisify-session-getblobdata branch from 0c7cc4c to f8e0e25 Mar 13, 2019

@codebytere codebytere force-pushed the promisify-session-getblobdata branch from f8e0e25 to c5fffe3 Mar 13, 2019

@zcbenz

zcbenz approved these changes Mar 14, 2019

@codebytere codebytere merged commit aa8b66a into master Mar 14, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190313.19 succeeded
Details
electron-arm64-testing Build #20190313.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 14, 2019

Release Notes Persisted

Converted session.getBlobData() to return a Promise instead of taking a callback.

@codebytere codebytere deleted the promisify-session-getblobdata branch Mar 14, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.