fix: remove label/image from segment if they are mutated to null #17323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
approved these changes
Mar 11, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "5-0-x", please check out #17334 |
|
I have automatically backported this PR to "4-0-x", please check out #17335 |
|
I have automatically backported this PR to "3-1-x", please check out #17336 |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The way we manage segmented controls is mutating them in place to match the new properties. This had issues when "label" or "image" wasn't just changed, rather completely removed / reset to
null.This PR updates the logic to handle the null/undefined cases.
Fixes #17322
Notes: TouchBarSegmentedControl instances now correctly update when you update the
segmentsarray and removelabelorimagedynamically.