Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove label/image from segment if they are mutated to null #17334

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Mar 11, 2019

Backport of #17323

See that PR for details.

Notes: TouchBarSegmentedControl instances now correctly update when you update the segments array and remove label or image dynamically.

@codebytere codebytere changed the title fix: remove label/image from segment if they are mutated to null (backport: 5-0-x) fix: remove label/image from segment if they are mutated to null Mar 11, 2019

@MarshallOfSound MarshallOfSound merged commit 6a93200 into electron:5-0-x Mar 12, 2019

8 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 12, 2019

Release Notes Persisted

TouchBarSegmentedControl instances now correctly update when you update the segments array and remove label or image dynamically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.