Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: promisify In-App Purchase #17355

Merged
merged 2 commits into from Mar 13, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 12, 2019

Description of Change

Promisifies inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

Checklist

Release Notes

Notes: Promisified inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

@codebytere codebytere force-pushed the promisify-iap branch from 51ebac4 to 392536e Mar 12, 2019

@codebytere codebytere marked this pull request as ready for review Mar 12, 2019

@codebytere codebytere requested review from deepak1556, zcbenz and miniak Mar 12, 2019

@miniak
Copy link
Contributor

left a comment

missing deprecate.promisify in lib/browser/api/in-app-purchase.js

docs/api/in-app-purchase.md Show resolved Hide resolved
spec/api-in-app-purchase-spec.js Outdated Show resolved Hide resolved
spec/api-in-app-purchase-spec.js Outdated Show resolved Hide resolved
spec/api-in-app-purchase-spec.js Outdated Show resolved Hide resolved

@codebytere codebytere force-pushed the promisify-iap branch from 00b1322 to 9e3ba1a Mar 12, 2019

@miniak

miniak approved these changes Mar 12, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 13, 2019

@codebytere codebytere merged commit 3e5a98b into master Mar 13, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190312.31 succeeded
Details
electron-arm64-testing Build #20190312.31 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 13, 2019

Release Notes Persisted

Promisified inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

@codebytere codebytere deleted the promisify-iap branch Mar 13, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

feat: promisify In-App Purchase (electron#17355)
* feat: promisify In-App Purchase

* use mate::Arguments in GetProducts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.