Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix default_app showMessageBox #17357

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@codebytere
Copy link
Member

codebytere commented Mar 12, 2019

Description of Change

Fix for

default_app/default_app.ts(84,5): error TS2554: Expected 1-2 arguments, but got 3.
default_app/default_app.ts(84,50): error TS7006: Parameter 'response' implicitly has an 'any' type.

cc @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere merged commit 5eb75e9 into master Mar 12, 2019

6 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 12, 2019

No Release Notes

@codebytere codebytere deleted the fix-tsc branch Mar 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.