Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native emoji picker #17359

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 12, 2019

Description of Change

Resolves #17358.

Adds native color picker for MacOS and emoji picker for MacOS and Windows.

Checklist

Release Notes

Notes: feat: add native emoji and color picker methods for Windows and MacOS.

Show resolved Hide resolved docs/api/app.md Outdated

@codebytere codebytere changed the title feat: add native emoji and color pickers [wip] feat: add native emoji and color pickers Mar 13, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 13, 2019

@nitsakh

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Would be nice to have isEmojiPanelSupported or similar API also, considering the chromium comment here => https://cs.chromium.org/chromium/src/ui/base/emoji/emoji_panel_helper_win.cc?rcl=cc008d5de58a291bd5874cfd2cccb508770c6cfd&l=17

@codebytere codebytere changed the title [wip] feat: add native emoji and color pickers [wip] feat: add native emojipicker Mar 14, 2019

@codebytere codebytere changed the title [wip] feat: add native emojipicker [wip] feat: add native emoji picker Mar 14, 2019

@codebytere codebytere changed the title [wip] feat: add native emoji picker feat: add native emoji picker Mar 14, 2019

@codebytere codebytere force-pushed the add-emoji-picker branch 3 times, most recently from 06e9133 to 0a68e6c Mar 14, 2019

@nitsakh
Copy link
Contributor

left a comment

Nice! 👍

@codebytere codebytere force-pushed the add-emoji-picker branch from 42a2e7b to 06275fb Mar 14, 2019

@codebytere codebytere merged commit 12b6a0f into master Mar 14, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190314.16 succeeded
Details
electron-arm64-testing Build #20190314.16 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 14, 2019

Release Notes Persisted

Added native emoji and color picker methods for Windows and MacOS.

@codebytere codebytere deleted the add-emoji-picker branch Mar 14, 2019

@pashvin

This comment has been minimized.

Copy link

commented Mar 29, 2019

@codebytere Thanks for giving us this API. If I want to try this new API, which build I should pickup and how I can invoke this API? Is this available in latest 4.x or 5.x(beta)?

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@pashvin It will be available from 6.0 onwards so the next nightly will pick it up 👍

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.