Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make applicationMenu a property on app #17361

Merged
merged 1 commit into from Apr 2, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 12, 2019

Description of Change

This PR converts applicationMenu to a proper JS property on app, so that users can use get and set on properties instead of using getApplicationMenu and setApplicationMenu.

cc @MarshallOfSound @nornagon @miniak

Checklist

Release Notes

Notes: Converted applicationMenu to a proper JS property on the app module.

@codebytere codebytere force-pushed the app-appmenu-prop branch from 0cba6ce to 41a20a9 Mar 13, 2019

@codebytere codebytere changed the title refactor: make applicationMenu a property on app [wip] refactor: make applicationMenu a property on app Mar 13, 2019

@codebytere codebytere force-pushed the app-appmenu-prop branch from 41a20a9 to dcc49d9 Mar 13, 2019

@codebytere codebytere changed the title [wip] refactor: make applicationMenu a property on app refactor: make applicationMenu a property on app Mar 13, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 13, 2019

@codebytere codebytere force-pushed the app-appmenu-prop branch from dcc49d9 to 2fecc6e Apr 2, 2019

@codebytere codebytere removed the wip label Apr 2, 2019

@codebytere codebytere force-pushed the app-appmenu-prop branch from 2fecc6e to 7dcd78c Apr 2, 2019

@codebytere codebytere merged commit 0431997 into master Apr 2, 2019

14 of 15 checks passed

Artifact Comparison
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190402.19 succeeded
Details
electron-arm64-testing Build #20190402.19 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 2, 2019

Release Notes Persisted

Converted applicationMenu to a proper JS property on the app module.

@codebytere codebytere deleted the app-appmenu-prop branch Apr 2, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.