Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make accessibilitySupportEnabled a property on app #17362

Merged
merged 3 commits into from Apr 5, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 13, 2019

Description of Change

This PR converts accessibilitySupportEnabled to a proper JS property on app, so that users can use get and set on properties instead of using app.isAccessibilitySupportEnabled() and app.setAccessibilitySupportEnabled(enabled).

Checklist

Release Notes

Notes: Converted accessibilitySupportEnabled to a proper JS property on app.

@codebytere codebytere force-pushed the app-accessibility-prop branch from 3c93d31 to e8f6c60 Mar 13, 2019

@codebytere codebytere changed the title refactor: make accessibilitySupport a prop on app refactor: make accessibilitySupport a propert on app Mar 13, 2019

@codebytere codebytere changed the title refactor: make accessibilitySupport a propert on app [wip] refactor: make accessibilitySupport a propert on app Mar 13, 2019

@codebytere codebytere force-pushed the app-accessibility-prop branch 2 times, most recently from 5fc14c0 to bb4fdf0 Mar 13, 2019

@codebytere codebytere changed the title [wip] refactor: make accessibilitySupport a propert on app refactor: make accessibilitySupport a propert on app Mar 13, 2019

@codebytere codebytere added the wip label Mar 13, 2019

@codebytere codebytere changed the title refactor: make accessibilitySupport a propert on app refactor: make accessibilitySupport a property on app Mar 13, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 14, 2019

@codebytere codebytere changed the title refactor: make accessibilitySupport a property on app refactor: make accessibilitySupportEnabled a property on app Mar 19, 2019

@codebytere codebytere force-pushed the app-accessibility-prop branch from bb4fdf0 to b8c45b5 Mar 19, 2019

@codebytere codebytere force-pushed the app-accessibility-prop branch 5 times, most recently from 3ff0f21 to cbc8c70 Apr 2, 2019

@codebytere codebytere force-pushed the app-accessibility-prop branch from 94fd209 to 02df7ac Apr 4, 2019

@codebytere codebytere requested a review from MarshallOfSound Apr 4, 2019

@codebytere codebytere merged commit 9c3cb55 into master Apr 5, 2019

14 of 15 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190405.1 succeeded
Details
electron-arm64-testing Build #20190405.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 5, 2019

Release Notes Persisted

Converted accessibilitySupportEnabled to a proper JS property on app.

@codebytere codebytere deleted the app-accessibility-prop branch Apr 5, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

refactor: make accessibilitySupportEnabled a property on app (electro…
…n#17362)

* refactor: make accessibilitySupport a prop on app

* fix docs

* update spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.