Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't crash when nativeImage.createFromBuffer() is called with invalid buffer (backport: 4-0-x) #17373

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

trop bot commented Mar 13, 2019

Backport of #17344

See that PR for details.

Notes: Fixed crash when nativeImage.createFromBuffer() is called with invalid buffer.

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 13, 2019

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

Blocking pending 4.1

@MarshallOfSound MarshallOfSound changed the base branch from 4-0-x to 4-1-x Mar 19, 2019

@MarshallOfSound
Copy link
Member

MarshallOfSound left a comment

Merging into 4-1-x

@MarshallOfSound MarshallOfSound merged commit 5e665c1 into electron:4-1-x Mar 19, 2019

4 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 19, 2019

Release Notes Persisted

Fixed crash when nativeImage.createFromBuffer() is called with invalid buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.