Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add systemPreferences.getAnimationSettings() #17382

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@miniak
Copy link
Contributor

commented Mar 14, 2019

Description of Change

Expose system animation settings provided by https://cs.chromium.org/chromium/src/ui/gfx/animation/animation.h

Checklist

Release Notes

Notes: Added systemPreferences.getAnimationSettings() returning system animation settings provided by Chromium.

@miniak miniak requested review from alexeykuzmin and codebytere Mar 14, 2019

@miniak miniak self-assigned this Mar 14, 2019

@codebytere

This comment has been minimized.

Copy link
Member

commented Mar 14, 2019

@miniak what was the motivation for this change? I'd potentially like to avoid adding methods to modules with no clear community requests or identified use cases 🤔

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2019

@codebytere we would like to use this API in Teams to adjust our animations

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 15, 2019

@MarshallOfSound MarshallOfSound merged commit 4c51fa9 into master Mar 19, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190314.6 succeeded
Details
electron-arm64-testing Build #20190314.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Added a new systemPreferences.getAnimationSettings() API that returns the system animation settings provided by Chromium. Useful to determine what kinda of animation your app should use.

@MarshallOfSound MarshallOfSound deleted the miniak/get-animation-settings branch Mar 19, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.