Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tray.getTitle() #17385

Merged
merged 2 commits into from Mar 18, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 14, 2019

Description of Change

This PR adds a getter for the tray title on macOS. This allows a user to programmatically ensure that setTitle took effect as well as acting as a precursor for making title a property on the Tray module, which would necessitate both a getter and setter where only a setter existed before.

Also cleans up methods within defines so that the title setter and getter don't have to be implemented cross-platform emptily.

cc @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: Added tray.getTitle() to allows users to see the title set next to the status bar icon on macOS.

@MarshallOfSound
Copy link
Member

left a comment

Can we add a spec to ensure that setting then getting does as expected 👍

@codebytere

This comment has been minimized.

Copy link
Member Author

commented Mar 14, 2019

@codebytere codebytere force-pushed the tray-gettitle branch from 2e79206 to 6b1ec37 Mar 14, 2019

@codebytere codebytere force-pushed the tray-gettitle branch from 6b1ec37 to 0f8486a Mar 14, 2019

@codebytere codebytere changed the title feat: add tray.getTitle feat: add tray.getTitle() Mar 14, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 15, 2019

@miniak

miniak approved these changes Mar 18, 2019

@codebytere codebytere merged commit 2fb9085 into master Mar 18, 2019

12 of 13 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190314.26 succeeded
Details
electron-arm64-testing Build #20190314.25 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 18, 2019

Release Notes Persisted

Added tray.getTitle() to allows users to see the title set next to the status bar icon on macOS.

@codebytere codebytere deleted the tray-gettitle branch Mar 18, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

feat: add tray.getTitle() (electron#17385)
* feat: add tray.getTitle

* fix spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.