Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable NodeIntegrationInSubFrames for webview (5-0-x) #17398

Merged

Conversation

Projects
None yet
2 participants
@brenca
Copy link
Member

commented Mar 15, 2019

Description of Change

Manual backport of #17226.
Depends on #17396 for the node backport to land in 5-0-x.

This was previously not done because of a crash. electron/node#94 fixes that crash, and allow us to enable this option for the webview. The node PR also fixes #16733.

Fixes #16780.

Checklist

Release Notes

Notes: Enabled NodeIntegrationInSubFrames option usage for webview tags.

@brenca brenca requested a review from MarshallOfSound Mar 15, 2019

@trop trop bot referenced this pull request Mar 15, 2019

Merged

feat: enable NodeIntegrationInSubFrames for webview #17226

6 of 6 tasks complete

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 16, 2019

@MarshallOfSound
Copy link
Member

left a comment

Nice 💯

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

Approved for merge to 5-0-x by @electron/wg-releases here --> #17226 (review)

@MarshallOfSound MarshallOfSound merged commit 1b8a25b into 5-0-x Mar 19, 2019

11 of 12 checks passed

Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190315.10 succeeded
Details
electron-arm64-testing Build #20190315.10 succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Enabled NodeIntegrationInSubFrames option usage for webview tags.

@MarshallOfSound MarshallOfSound deleted the brenca/node-integration-subframes-webview-5-0-x branch Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.