Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow windows to be excluded from the windows menu #17404

Merged
merged 3 commits into from Mar 27, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 15, 2019

Description of Change

Resolves #17193.

Allows for windows to be excluded from the windows menu so that they don't appear in either the dock or the primary application menu.

Before:
Screen Shot 2019-03-15 at 2 13 11 PM

After:
Screen Shot 2019-03-15 at 2 17 28 PM

Checklist

Release Notes

Notes: Added excludedFromShownWindowsMenu property to allow for windows to be excluded from the windows menu.

@codebytere codebytere force-pushed the tl-exclude-dock branch from 730405c to d3e33a7 Mar 15, 2019

@codebytere codebytere force-pushed the tl-exclude-dock branch from d3e33a7 to cda1afa Mar 15, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 16, 2019

@codebytere codebytere force-pushed the tl-exclude-dock branch 5 times, most recently from c013f77 to f6b36d1 Mar 18, 2019

@codebytere codebytere requested a review from MarshallOfSound Mar 22, 2019

@codebytere codebytere force-pushed the tl-exclude-dock branch from f6b36d1 to f9c900e Mar 22, 2019

@MarshallOfSound
Copy link
Member

left a comment

Looking good 👍

@codebytere codebytere merged commit 4e57a73 into master Mar 27, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190322.6 succeeded
Details
electron-arm64-testing Build #20190322.6 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 27, 2019

Release Notes Persisted

Added excludedFromShownWindowsMenu property to allow for windows to be excluded from the windows menu.

@codebytere codebytere deleted the tl-exclude-dock branch Mar 27, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

feat: allow windows to be excluded from the windows menu (electron#17404
)

* feat: allow windows to be excluded from the windows menu

* excludedfromWindowsMenu => excludedFromShownWindowsMenu

* implement no-op for win & linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.