Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose colorSpace to display object #17405

Merged
merged 3 commits into from Mar 19, 2019

Conversation

@codebytere
Copy link
Member

commented Mar 15, 2019

Description of Change

Exposes colorSpace to the display object from chromium. I did some digging into how we could potentially expose this as an object instead of a string, but there's no way to access the private member variables we'd need to do so without patching chromium, and i'd like to avoid that.

cc @miniak

Example output:

  colorSpace:
   '{primaries_d50_referred: [[0.6587, 0.3332],  [0.3206, 0.6135],  [0.1508, 0.0527]], transfer:0.0777*x + 0.0000 if x < 0.0450 else (0.9478*x + 0.0521)**2.4000 + 0.0002, matrix:RGB, range:FULL}',

Checklist

Release Notes

Notes: Exposed colorSpace to the Display object

@codebytere codebytere changed the title feat: expose colorSpace to display object [wip] feat: expose colorSpace to display object Mar 15, 2019

@codebytere codebytere added the wip label Mar 15, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 16, 2019

@codebytere codebytere marked this pull request as ready for review Mar 19, 2019

@codebytere codebytere removed the wip label Mar 19, 2019

@codebytere codebytere changed the title [wip] feat: expose colorSpace to display object feat: expose colorSpace to display object Mar 19, 2019

@codebytere codebytere requested a review from miniak Mar 19, 2019

@miniak

miniak approved these changes Mar 19, 2019

@MarshallOfSound MarshallOfSound merged commit 1d93bc7 into master Mar 19, 2019

11 of 13 checks passed

electron-arm-testing
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190319.38 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Exposed the colorSpace property to the Display object that is returned from the screen APIs

@MarshallOfSound MarshallOfSound deleted the display-color-display branch Mar 19, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

feat: expose colorSpace to display object (electron#17405)
* feat: expose colorSpace to display object

* update doc

* add a spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.