Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add <webview>.getWebContentsId() #17407

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@miniak
Copy link
Contributor

commented Mar 16, 2019

Description of Change

Allows getting the WebContents ID of <webview>s when the remote module is disabled.

Checklist

Release Notes

Notes: Added <webview>.getWebContentsId(), which does not depend of the remote module.

@electron-cation electron-cation bot added new-pr 🌱 and removed new-pr 🌱 labels Mar 16, 2019

@miniak miniak requested a review from nornagon Mar 19, 2019

@miniak miniak self-assigned this Mar 19, 2019

@miniak miniak marked this pull request as ready for review Mar 19, 2019

@miniak miniak requested a review from zcbenz Mar 19, 2019

@miniak miniak force-pushed the miniak/webview-webcontents-id branch from abc5cfe to 8d026cf Mar 19, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Mar 19, 2019

@zcbenz, @deepak1556 is it ok to use webContents ID as guestInstanceId to make the implementation simple?

@zcbenz

zcbenz approved these changes Mar 19, 2019

@zcbenz

This comment has been minimized.

Copy link
Member

commented Mar 19, 2019

@zcbenz, @deepak1556 is it ok to use webContents ID as guestInstanceId to make the implementation simple?

I think it is fine, and it does make code easier to understand.

@deepak1556
Copy link
Member

left a comment

Agree with cheng here, there is no functionality change and it simplifies the code, webContents id is also an ever increasing unique id generated by the browser process.

@zcbenz zcbenz merged commit 546466b into master Mar 26, 2019

10 of 13 checks passed

build-linux Workflow: build-linux
Details
electron-arm-testing
Details
Artifact Comparison Changes Detected
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190326.3 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 26, 2019

Release Notes Persisted

Added <webview>.getWebContentsId(), which does not depend of the remote module.

@zcbenz zcbenz deleted the miniak/webview-webcontents-id branch Mar 26, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.