Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove crashReporterRenderer.sendSync() workaround (5-0-x) #17410

Merged
merged 1 commit into from Mar 19, 2019

Conversation

2 participants
@miniak
Copy link
Contributor

commented Mar 16, 2019

Description of Change

Remove crashReporterRenderer.sendSync(), allows sending internal IPCs. This should not be exposed to application code. Based on #16729.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@miniak miniak changed the title fix: remove crashReporterRenderer.sendSync() workaround (4-1-x) fix: remove crashReporterRenderer.sendSync() workaround (5-0-x) Mar 16, 2019

@miniak miniak self-assigned this Mar 16, 2019

@miniak miniak requested review from MarshallOfSound, alexeykuzmin, nornagon and electron/wg-releases and removed request for MarshallOfSound Mar 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 17, 2019

@MarshallOfSound MarshallOfSound merged commit 7912ea5 into 5-0-x Mar 19, 2019

6 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

No Release Notes

@MarshallOfSound MarshallOfSound deleted the miniak/crash-reporter-init_5-0-x branch Mar 19, 2019

@sofianguy sofianguy added this to Fixed in 5.0.0-beta.6 in 5.0.x Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.