Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove special handling for dialog methods in remote module #17412

Merged
merged 2 commits into from Mar 19, 2019

Conversation

@miniak
Copy link
Contributor

commented Mar 16, 2019

Description of Change

This workaround is no longer applicable after the dialog methods have been promisified and separate synchronous versions have been added.

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

Release Notes

Notes: Removed special handling that forced dialog methods called over the remote module to return their result synchronously but not block the main process.

/cc @codebytere

@miniak miniak marked this pull request as ready for review Mar 16, 2019

@miniak miniak force-pushed the miniak/dialog-async-cleanup branch from 4d41f79 to a12276f Mar 16, 2019

@miniak miniak self-assigned this Mar 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 17, 2019

@MarshallOfSound
Copy link
Member

left a comment

Approving and tagging with semver/major to prevent backports as although this isn't technically an API surface it could break people that are using it without realizing

@MarshallOfSound MarshallOfSound merged commit 06a4594 into master Mar 19, 2019

13 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190316.22 succeeded
Details
electron-arm64-testing Build #20190316.22 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Removed special handling that forced dialog methods called over the remote module to return their result synchronously but not block the main process.

@MarshallOfSound MarshallOfSound deleted the miniak/dialog-async-cleanup branch Mar 19, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

chore: remove special handling for dialog methods in remote module (e…
…lectron#17412)

* chore: remove special handling for dialog methods in remote module

* refactor: remove callFunction helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.