Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report module name when require fails in sandboxed renderers #17413

Merged
merged 1 commit into from Mar 19, 2019

Conversation

@miniak
Copy link
Contributor

commented Mar 16, 2019

Description of Change

Added missing module name to the exception message thrown when require fails in sandboxed renderers. Follow up to chore: remove deprecated modules internally using remote.require in sandboxed renderer context

Checklist

Release Notes

Notes: Added missing module name to the exception message thrown when require fails in sandboxed renderers.

/cc @tarruda

@miniak miniak requested a review from tarruda Mar 16, 2019

@miniak miniak self-assigned this Mar 16, 2019

@miniak miniak added target/5-0-x and removed target/5-0-x labels Mar 16, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 17, 2019

@MarshallOfSound MarshallOfSound merged commit 7389dfc into master Mar 19, 2019

11 of 14 checks passed

build-mac Workflow: build-mac
Details
electron-arm64-testing Build #20190316.14 has test failures
Details
Backportable? - 5-0-x Cancelled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
electron-arm-testing Build #20190316.14 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Added missing module name to the exception message thrown when require fails in sandboxed renderers.

@MarshallOfSound MarshallOfSound deleted the miniak/sandbox-require-error branch Mar 19, 2019

@miniak

This comment has been minimized.

Copy link
Contributor Author

commented Apr 4, 2019

/trop run backport-to 5-0-x

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop

This comment has been minimized.

Copy link
Contributor

commented Apr 4, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.