Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when inserting menu items out-of-range (backport: 5-0-x) #17435

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

commented Mar 18, 2019

Backport of #17401

See that PR for details.

Notes: Added a check for invalid menu index to prevent out-of-range crashes on insertion.

@trop trop bot referenced this pull request Mar 18, 2019

Merged

fix: throw error when inserting menu items out-of-range #17401

5 of 5 tasks complete

@trop trop bot added 5-0-x backport labels Mar 18, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 18, 2019

@MarshallOfSound MarshallOfSound merged commit 361e5b2 into electron:5-0-x Mar 19, 2019

6 of 8 checks passed

appveyor: win-ia32-testing-pr AppVeyor build cancelled
Details
appveyor: win-x64-testing-pr AppVeyor build cancelled
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 19, 2019

Release Notes Persisted

Added a check for invalid menu index to prevent out-of-range crashes on insertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.