Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FrameSubscriber should not scale frame down #17444

Merged
merged 1 commit into from Apr 8, 2019

Conversation

@zcbenz
Copy link
Member

commented Mar 19, 2019

Description of Change

The beginFrameSubscription currently passes the DIP size to Chromium, which would then scale the frame down and return blurred image on HiDPI displays.

This PR changes the code to pass pixel size, so the API works correctly on HiDPI displays.

Checklist

Release Notes

Notes: Fix beginFrameSubscription returning blurred images on HiDPI displays.

@zcbenz zcbenz requested a review from brenca Mar 19, 2019

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 20, 2019

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

@zcbenz This is now in conflict 😢

@zcbenz zcbenz force-pushed the frame-original-size branch from bc877a0 to 2c0085f Apr 8, 2019

@zcbenz

This comment has been minimized.

Copy link
Member Author

commented Apr 8, 2019

I have rebased the branch.

@zcbenz zcbenz merged commit e7c4892 into master Apr 8, 2019

15 checks passed

Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-debug AppVeyor build succeeded
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-debug AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-linux Workflow: build-linux
Details
build-mac Workflow: build-mac
Details
electron-arm-testing Build #20190408.1 succeeded
Details
electron-arm64-testing Build #20190408.1 succeeded
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Apr 8, 2019

Release Notes Persisted

Fix beginFrameSubscription returning blurred images on HiDPI displays.

@zcbenz zcbenz deleted the frame-original-size branch Apr 8, 2019

Kiku-Reise added a commit to Kiku-Reise/electron that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.