Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw error when inserting menu items out-of-range #17461

Conversation

Projects
None yet
2 participants
@trop
Copy link
Contributor

trop bot commented Mar 19, 2019

Backport of #17434

See that PR for details.

Notes: Added a check for invalid menu index to prevent out-of-range crashes on insertion.

@codebytere codebytere changed the title fix: throw error when inserting menu items out-of-range (backport: 4-0-x) (backport: 4-1-x) fix: throw error when inserting menu items out-of-range Mar 19, 2019

@MarshallOfSound MarshallOfSound merged commit ee15295 into electron:4-1-x Mar 19, 2019

2 of 4 checks passed

appveyor: win-ia32-testing-pr Waiting for AppVeyor build to complete
Details
appveyor: win-x64-testing-pr Waiting for AppVeyor build to complete
Details
Semantic Pull Request ready to be squashed
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 19, 2019

Release Notes Persisted

Added a check for invalid menu index to prevent out-of-range crashes on insertion.

@MarshallOfSound MarshallOfSound added 4-1-x and removed 4-1-x labels Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.