Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Use correct image URL on `docs/tutorial/windows-taskbar.md` #17467

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@klaussinani
Copy link
Contributor

commented Mar 19, 2019

Description of Change

The PR removes the following broken URL:

used for the "Tasks of Internet Explorer" image, on the docs/tutorial/windows-taskbar.md file,
and replaces it with the correct one:

As a sanity check, the new image URL uses the same domain name, https://i-msdn.sec.s-msft, as the other 2 in the file:

Fixes #17387.

Preview

Old URL New URL
IE IE

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • tests are changed or added
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: Use correct image URL on docs/tutorial/windows-taskbar.md

@ghost

This comment has been minimized.

Copy link

commented Mar 19, 2019

Super! Thank you for caring about my issue klaus and fixing it! 🎉

@codebytere
Copy link
Member

left a comment

thanks!

@MarshallOfSound MarshallOfSound merged commit 1c7b302 into electron:master Mar 20, 2019

8 of 9 checks passed

build-linux Workflow: build-linux
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
build-mac Workflow: build-mac
Details
lint Workflow: lint
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 20, 2019

Release Notes Persisted

Use correct image URL on docs/tutorial/windows-taskbar.md

@welcome

This comment has been minimized.

Copy link

commented Mar 20, 2019

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.