Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a more unique identifier for NSUserNotification instances (backport: 3-1-x) #17482

Conversation

Projects
None yet
3 participants
@trop
Copy link
Contributor

commented Mar 20, 2019

Backport of #17469

See that PR for details.

Notes: Fixed an issue where Notification objects constructed in the main process would randomly not be shown to the user.

fix: use a more unique identifier for NSUserNotification instances
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented.  They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.

As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions.  The identifier now consists of a
randomly generated UUID and the app bundle id.

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 20, 2019

@MarshallOfSound MarshallOfSound merged commit fd60283 into electron:3-1-x Mar 20, 2019

11 of 12 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
build-arm Workflow: build-arm
Details
build-arm64 Workflow: build-arm64
Details
build-ia32 Workflow: build-ia32
Details
build-mas-x64 Workflow: build-mas-x64
Details
build-osx-x64 Workflow: build-osx-x64
Details
build-x64 Workflow: build-x64
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 20, 2019

Release Notes Persisted

Fixed an issue where Notification objects constructed in the main process would randomly not be shown to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.