Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a more unique identifier for NSUserNotification instances (backport: 4-1-x) #17483

Conversation

Projects
None yet
4 participants
@trop
Copy link
Contributor

trop bot commented Mar 20, 2019

Backport of #17469

See that PR for details.

Notes: Fixed an issue where Notification objects constructed in the main process would randomly not be shown to the user.

fix: use a more unique identifier for NSUserNotification instances
So although apple has it documented that notifications with duplicate identifiers in the same session won't be presented.  They apparently forgot to mention that macOS also non-deterministically and without any errors, logs or warnings will also not present some notifications in future sessions if they have a previously used identifier.

As such, we're going to truly randomize these identifiers so they are
unique between apps and sessions.  The identifier now consists of a
randomly generated UUID and the app bundle id.

@electron-cation electron-cation bot removed the new-pr 🌱 label Mar 20, 2019

@MarshallOfSound MarshallOfSound merged commit a0d824c into electron:4-1-x Mar 20, 2019

3 of 4 checks passed

appveyor: win-ia32-testing-pr AppVeyor build failed
Details
Semantic Pull Request ready to be squashed
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 20, 2019

Release Notes Persisted

Fixed an issue where Notification objects constructed in the main process would randomly not be shown to the user.

@MarshallOfSound MarshallOfSound added 4-1-x and removed 4-1-x labels Mar 20, 2019

@orangeChu

This comment has been minimized.

Copy link

orangeChu commented Mar 26, 2019

It was finally fixed, thank you very much! 😃 I once thought that my coding problem caused the notification to not be displayed. 😱

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.