Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backport KDE icon size fix #17497

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@MarshallOfSound
Copy link
Member

MarshallOfSound commented Mar 21, 2019

The code that adds padding to too small icons was breaking the larger ones by cutting the minimal size (22x22px) out of their center.

Backports: https://chromium-review.googlesource.com/c/chromium/src/+/1173235

Release Notes

Notes: Fixed issue on KDE where tray icons would be displayed incorrectly as a 22x22 version of the provided tray image but cropped from the center

@MarshallOfSound MarshallOfSound changed the title [WIP] fix: backport KDE icon size fix fix: backport KDE icon size fix Mar 21, 2019

@ckerr

ckerr approved these changes Mar 21, 2019

@ckerr ckerr merged commit 7b1f5a9 into 4-1-x Mar 21, 2019

6 checks passed

Semantic Pull Request ready to be squashed
Details
appveyor: win-ia32-testing AppVeyor build succeeded
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
appveyor: win-x64-testing AppVeyor build succeeded
Details
appveyor: win-x64-testing-pr AppVeyor build succeeded
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

release-clerk bot commented Mar 21, 2019

Release Notes Persisted

Fixed issue on KDE where tray icons would be displayed incorrectly as a 22x22 version of the provided tray image but cropped from the center

@ckerr ckerr deleted the backport-kde-icon-fix branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.