Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libcc (3-1-x) #17503

Conversation

Projects
None yet
2 participants
@roller-bot
Copy link
Contributor

commented Mar 21, 2019

Updating libcc reference to latest. Changes since the last roll:

ci: Move MacOS builds to CircleCI

The code that adds padding to too small icons was breaking the larger
ones by cutting the minimal size (22x22px) out of their center.

Backports: https://chromium-review.googlesource.com/c/chromium/src/+/1173235

Notes: no-notes

@MarshallOfSound

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Windows CI is a known flake on 3-1-x 👍

@MarshallOfSound MarshallOfSound merged commit 400f054 into electron:3-1-x Mar 21, 2019

11 of 12 checks passed

appveyor: win-x64-testing-pr AppVeyor build failed
Details
Artifact Comparison No Changes
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
appveyor: win-ia32-testing-pr AppVeyor build succeeded
Details
build-arm Workflow: build-arm
Details
build-arm64 Workflow: build-arm64
Details
build-ia32 Workflow: build-ia32
Details
build-mas-x64 Workflow: build-mas-x64
Details
build-osx-x64 Workflow: build-osx-x64
Details
build-x64 Workflow: build-x64
Details
release-notes Release notes found
@release-clerk

This comment has been minimized.

Copy link

commented Mar 21, 2019

Release Notes Persisted

Fixed issue on KDE where tray icons would be displayed incorrectly as a 22x22 version of the provided tray image but cropped from the center

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.