Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
chore: update to chromium 75.0.3740.3 #17507
Another important change that went in this release is that windows builds switched to chromiums libc++ https://bugs.chromium.org/p/chromium/issues/detail?id=801780 , https://docs.google.com/document/d/1VPxepzuyWbXFzv1VpkSKEn0wPvSUffpcaOLislhcwrA/edit#heading=h.4r33ra48xro (check the design document). I think we should investigate the impact of this change.
Unsurprisingly the build errors are related to this :)
referenced this pull request
Mar 22, 2019
The design doc says:
I think we should probably go with
@KoenLav because of node native modules.
node native modules don't expect to be built against libc++ on windows & such may not compile. Additionally, we'd have to ship libc++'s headers with the electron header bundle and upstream changes to node-gyp and cmake-js to link against libc++ instead of msstl.
it's a complicated situation with no great answers. sticking with msstl is the easiest option in the short term, but we may have to figure out something else in the long run.